Special dice button sequencing / undo fix#14266
Open
riverwanderer wants to merge 17 commits intovassalengine:masterfrom
Open
Special dice button sequencing / undo fix#14266riverwanderer wants to merge 17 commits intovassalengine:masterfrom
riverwanderer wants to merge 17 commits intovassalengine:masterfrom
Conversation
…h dice roll. Creating a single masterCommand in DR(). Appending all actions (Hotkeys, Chat Report, Property Set, and the ShowResults command) to this single master command. Calling GameModule.getGameModule().sendAndLog(masterCommand) only once at the end of DR(). This process ensures that a single user action (the dice roll) generates one log entry, which then only requires one undo step to revert the entire sequence, correctted in previous Commit.
…sync with dice roll." This reverts commit 5873501. Accidentally pushed.
…atibility, defaulting the previousRolls to EMPTY.
Collaborator
Author
|
PR tested OK against the Undo and Remote sequencing issues reported in the linked issues. |
Collaborator
Author
|
Unfortunately, the change nerfs the Symbolic Dice button's Looping and the associated Pre & Post action Global Hotkeys. Doubly unfortunate, since these functions are really redundant and it would have been better if Logging/UnDo worked correctly, even without looping (which a GHK to a normal action button can accomplish). More work required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI (Gemini)-guided fix for 14237.
Summary from the AI sessions; changes primarily involve: