Add "require" option and beta image publish workflow#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #14
Currently, when comparing two values, we use the
.includes()function. For example:[1,2,3,4,5].includes(3)will returntruebecause the number3appears in the array"The quick brown fox jumps over the lazy dog".includes("fox")will returntruebecause the wordfoxis present in the stringThis is safer than using
x === yand works 99% of the time.The user who reported the issue says they have a condition for the keyword
anime. They want anything with that keyword to trigger a specific filter. They came across a movie containing the keywordbased on animewhich incorrectly triggered their condition, because we use the.include()function. So what happened was:"based on anime".includes("anime")->trueTo help with this I added a new
requireoption which will only returntrueif the values match exactly.Also, this change will first be released in the new
betaimage to allow the user to test it before we make a public release. This is because we don't want to accidentally brick people's existing implementations.Ignore the spacing changes they're just automatic formatting from an extension.