Remove non-functional "Add to RoadFlare" share-page button#6
Merged
variablefate merged 1 commit intomainfrom Apr 20, 2026
Merged
Remove non-functional "Add to RoadFlare" share-page button#6variablefate merged 1 commit intomainfrom
variablefate merged 1 commit intomainfrom
Conversation
The button set href to nostr:<npub>, but RoadFlare iOS does not register any URL scheme today, so tapping it never opened the app — best case it errored in Safari, worst case some unrelated Nostr client handled it. The copy button on Account ID and the QR code already provide the working paths for adding a driver/rider; the broken CTA only created confusion. A driver-only replacement using a future roadflared: scheme is drafted in #4 (pairs with variablefate/roadflare-ios#64). A rider-only replacement using roadflarer: is drafted in #5, waiting on a future iOS driver app. This commit clears the way for both by removing the placeholder element and its JS handler. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Add to RoadFlare" primary CTA on
/share/d/<npub>and/share/r/<npub>set its href tonostr:<npub>, but RoadFlare iOS does not register thenostr:URL scheme — so tapping the button either errored in Safari or dispatched to some unrelated Nostr client. Either way, it never opened RoadFlare. This PR removes the placeholder element and the JS that sets its href.Users already have two functional paths for adding a driver/rider:
The button's behavior on the live site has never been useful in a way those two flows don't already cover.
Follow-up
Two draft PRs are already open with scheme-specific replacements, each waiting on matching app-side support:
roadflared:<npub>, blocked on variablefate/roadflare-ios#64 (RoadFlare iOS registering the scheme)roadflarer:<npub>, blocked on a future iOS driver appBoth draft PRs are designed to cleanly rebase onto the post-merge state of this PR (they add new elements with new IDs rather than modifying the ones deleted here — non-conflicting in any merge order).
Diff
404.html:<a class="btn btn-primary" id="add-btn" href="#">Add to RoadFlare</a>from.actions// Deep link/document.getElementById('add-btn').href = 'nostr:' + npub;4 lines deleted, 0 added. No CSS / config / CNAME touched.
Test plan
/share/d/<real-npub>— profile renders, QR + copy button work, App Store button routes correctly, no "Add to RoadFlare" button present/share/r/<real-npub>— same as abovedocument.getElementById('add-btn')null-ref errors)🤖 Generated with Claude Code