feat(sdk): rethrow publishProfileAndMark + publishAndMark for eager onboarding banner

[variablefate]

Summary

• Promote RoadflareDomainService.publishProfileAndMark and ProfileBackupCoordinator.publishAndMark from async to async throws. Onboarding (runOnboardingPublishImpl) catches and fires the banner immediately when online instead of waiting the full 60s for the watchdog. ADR-0016's watchdog stays as the hang-case safety net.
• ProfileBackupCoordinator.publishAndMark preserves its republish-loop coalescing via a last-iteration-error semantic: a coalesced republish that succeeds rescues an earlier failure; only a terminal failure throws. Sessions invalidated by clearAll() return without throw.
• Non-onboarding callers (SyncCoordinator.flushPendingSyncPublishes, SyncDomainStrategy.publishLocal, settings/locations UI taps in SettingsTab / PaymentMethodsScreen / SavedLocationsView) wrap with try? to preserve best-effort contract — the dirty flag is still the source of truth there.
• Followed-drivers and ride-history publishXAndMark helpers stay async (no UI watchdog observes them).
• OnboardingPublishWatchdogTests gets two new tests: eager-fire-when-online and stay-quiet-when-offline-then-rearm.

ADR-0017 documents the decision and rationale. Closes Issue #97 item 2.

Test plan

• swift test (838 tests) — all pass; new publishProfileAndMarkRethrowsRelayFailure test exercises the throw, existing publishAndMarkFailurePathSkipsMarkPublished updated to expect the throw.
• xcodebuild ... test (full iOS test plan) — all pass; new eagerErrorSurfacesBannerBeforeWatchdogTimeoutWhenOnline asserts banner fires in <500ms with timeout configured to 60s (production value), eagerErrorStaysQuietWhenOffline asserts watchdog parking owns the offline path.
• Manual on-device verification deferred to Issue Onboarding publish-failure surface: device verification + 4 deferred follow-ups #97 item 1 (ride next TestFlight build): toggle airplane mode mid-ProfileSetup → tap Continue → expect banner near-instant on online toggle, not after 60s.

🤖 Generated with Claude Code

[variablefate]

Code review

Found 1 issue:

1. saveAndPublishSettings short-circuits on first throw, skipping the second publish. Pre-PR, both await publishProfile() and await publishProfileBackup() always ran (errors swallowed inside). Post-PR, try await publishProfile() followed by try await publishProfileBackup() aborts the second call when the first throws. In the eager-error catch (runOnboardingPublishImpl for .settingsBackup) this is compounded by onboardingPublishWatchdogTask?.cancel() — the watchdog that was the safety net for partial-failure cases (its isOnboardingDomainDirty(.settingsBackup) checks both .profile AND .profileBackup flags) is now cancelled, leaving the .profileBackup publish un-attempted until manual Retry or reconnectAndRestoreSession.flushPendingSyncPublishes. Consider capturing the first error but running both publishes before throwing, e.g. do { try await publishProfile() } catch { first = error }; do { try await publishProfileBackup() } catch { first = first ?? error }; if let first { throw first }.

roadflare-ios/RoadFlare/RoadFlareCore/ViewModels/AppState.swift

Lines 441 to 447 in dbca1d4

	}
	public func saveAndPublishSettings() async throws {
	try await publishProfile()
	try await publishProfileBackup()
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[variablefate]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}