Open
Conversation
added 6 commits
February 2, 2022 21:34
jinn2u
reviewed
Feb 5, 2022
Contributor
jinn2u
left a comment
There was a problem hiding this comment.
제 개인적인 생각으로 App에 너무 많은 책임이 있는것은 아닌가 라는 생각이 듭니다..!
저 같은 경우 App에는 여러 컴포넌트들에게 사용될 전역 상태를 저장 해 두었고, 인스턴스를 생성하는 역할과, body의 상태가 변경되는 로직만을 넣어두었습니다.
그게 아니라 새로운 컴포넌트를 만들기 싫다면 App의 render안에 작성해두는것이 더 가독성이 좋은것 같습니다.
져니는 어떻게 생각하나요?
| value: 'Change!!' | ||
| }, | ||
| onClick: ()=>{ | ||
| const linearGradient = Array(2).fill(0) |
Contributor
There was a problem hiding this comment.
랜덤 16진수를 만드는 함수가 따로 있더라구요..!
const randomHexColor = () => `#${Math.round(Math.random() * 0xffffff).toString(16)}`;참고하면 좋을것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
리뷰 시 참고 사항
실행 화면