Skip to content

fix(isISO6346): anchor regex alternation and remove stray comma #2771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DucMinhNe wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(isISO6346): anchor regex alternation and remove stray comma #2771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/isISO6346.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import assertString from './util/assertString';
// https://en.wikipedia.org/wiki/ISO_6346
// according to ISO6346 standard, checksum digit is mandatory for freight container but recommended
// for other container types (J and Z)
const isISO6346Str = /^[A-Z]{3}(U[0-9]{7})|([J,Z][0-9]{6,7})$/;
const isISO6346Str = /^[A-Z]{3}(U[0-9]{7}|[JZ][0-9]{6,7})$/;
const isDigit = /^[0-9]$/;

export function isISO6346(str) {
Expand Down
6 changes: 6 additions & 0 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13537,6 +13537,9 @@ describe('Validators', () => {
'ECMJ4657496',
'TBJA7176445',
'AFFU5962593',
'ABCU1234567GARBAGE', // trailing garbage after a valid prefix
'GARBAGEZ123456', // leading garbage before a valid suffix
'XYZ,123456', // comma is not a valid category identifier
],
});
});
Expand All @@ -13562,6 +13565,9 @@ describe('Validators', () => {
'ECMJ4657496',
'TBJA7176445',
'AFFU5962593',
'ABCU1234567GARBAGE', // trailing garbage after a valid prefix
'GARBAGEZ123456', // leading garbage before a valid suffix
'XYZ,123456', // comma is not a valid category identifier
],
});
});
Expand Down
Loading