Skip to content

Add more tests #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
XhmikosR wants to merge 1 commit into
base: main
Choose a base branch
from
+495 −0
Draft

Add more tests #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test/fixtures/folder (with) special [chars] & more/test+file#1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Test File with Special Characters</title>
</head>
<body>
<img src="test.png" invalidattr="">
<br clear="left">
</body>
</html>
10 changes: 10 additions & 0 deletions test/fixtures/folder with spaces/test file.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Test File with Spaces</title>
</head>
<body>
<img src="test.png" unknownattr="">
<br clear="all">
</body>
</html>
136 changes: 136 additions & 0 deletions test/html_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,4 +179,140 @@ describe('htmllint', () => {
run(options, expected, '3 errors from 3 files', done);
});
});

describe('file paths with special characters', () => {
it('with spaces (relative)', done => {
const filePath = path.normalize('test/fixtures/folder with spaces/test file.html');
const options = {
files: [filePath],
errorlevels: ['info', 'warning', 'error']
};
const expected = [
{
file: filePath,
type: 'error',
message: expectedResults.invalid[1].message,
lastLine: 7,
lastColumn: 39
},
{
file: filePath,
type: 'error',
message: expectedResults.invalid[2].message,
lastLine: 7,
lastColumn: 39
},
{
file: filePath,
type: 'error',
message: expectedResults.invalid[3].message,
lastLine: 8,
lastColumn: 20
}
];

run(options, expected, 'errors from file path with spaces', done);
});

it('with spaces (absolute)', done => {
const filePath = path.resolve('test/fixtures/folder with spaces/test file.html');
const options = {
files: [filePath],
absoluteFilePathsForReporter: true,
errorlevels: ['info', 'warning', 'error']
};
const expected = [
{
file: filePath,
type: 'error',
message: expectedResults.invalid[1].message,
lastLine: 7,
lastColumn: 39
},
{
file: filePath,
type: 'error',
message: expectedResults.invalid[2].message,
lastLine: 7,
lastColumn: 39
},
{
file: filePath,
type: 'error',
message: expectedResults.invalid[3].message,
lastLine: 8,
lastColumn: 20
}
];

run(options, expected, 'errors from absolute file path with spaces', done);
});

it('with various special characters (relative)', done => {
const filePath = path.normalize('test/fixtures/folder (with) special [chars] & more/test+file#1.html');
const options = {
files: [filePath],
errorlevels: ['info', 'warning', 'error']
};
const expected = [
{
file: filePath,
type: 'error',
message: expectedResults.invalid[1].message.replace('unknownattr', 'invalidattr'),
lastLine: 7,
lastColumn: 39
},
{
file: filePath,
type: 'error',
message: expectedResults.invalid[2].message,
lastLine: 7,
lastColumn: 39
},
{
file: filePath,
type: 'error',
message: expectedResults.invalid[3].message,
lastLine: 8,
lastColumn: 21
}
];

run(options, expected, 'errors from file path with special characters', done);
});

it('with various special characters (absolute)', done => {
const filePath = path.resolve('test/fixtures/folder (with) special [chars] & more/test+file#1.html');
const options = {
files: [filePath],
absoluteFilePathsForReporter: true,
errorlevels: ['info', 'warning', 'error']
};
const expected = [
{
file: filePath,
type: 'error',
message: expectedResults.invalid[1].message.replace('unknownattr', 'invalidattr'),
lastLine: 7,
lastColumn: 39
},
{
file: filePath,
type: 'error',
message: expectedResults.invalid[2].message,
lastLine: 7,
lastColumn: 39
},
{
file: filePath,
type: 'error',
message: expectedResults.invalid[3].message,
lastLine: 8,
lastColumn: 21
}
];

run(options, expected, 'errors from absolute file path with special characters', done);
});
});
});
Loading
Loading