feat: add kbs.extraSecrets for non-ESO secrets#15
Merged
beraldoleal merged 3 commits intovalidatedpatterns:mainfrom Mar 6, 2026
Merged
feat: add kbs.extraSecrets for non-ESO secrets#15beraldoleal merged 3 commits intovalidatedpatterns:mainfrom
beraldoleal merged 3 commits intovalidatedpatterns:mainfrom
Conversation
Allow adding pre-existing K8s Secrets to kbsSecretResources without creating ExternalSecrets. Useful for secrets created by imperative jobs or other controllers outside the Vault flow. Signed-off-by: Beraldo Leal <bleal@redhat.com>
butler54
approved these changes
Mar 6, 2026
Collaborator
|
@beraldoleal. You should be able to merge now can you do the following (i've left it open so you can make changes w/o needing re-approval)
|
Collaborator
|
@sabre1041 ^^ we should have a discussion on how messy this release process is with the wider team |
IIUC, the semantic ver is not triggered yet. And we need a 0.2.1 Signed-off-by: Beraldo Leal <bleal@redhat.com>
just a make helm-docs Signed-off-by: Beraldo Leal <bleal@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow adding pre-existing K8s Secrets to kbsSecretResources without creating ExternalSecrets. Useful for secrets created by imperative jobs or other controllers outside the Vault flow.