Skip to content

Update golangci-lint to v2.10.1 #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbaldessari wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update golangci-lint to v2.10.1 #513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ed6c0c
Update golangci-lint to v2.10.1
mbaldessari Mar 3, 2026
d2775e4
Fix linter error
mbaldessari Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Run golangci-lint
uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
with:
version: v2.8.0
version: v2.10.1
args: --timeout 5m -v

#--exclude SA5011
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ GOFLAGS=-mod=vendor
REGISTRY ?= localhost
UPLOADREGISTRY ?= quay.io/validatedpatterns
GOLANGCI_IMG ?= docker.io/golangci/golangci-lint
GOLANGCI_VERSION ?= 2.8.0
GOLANGCI_VERSION ?= 2.10.1

# CI uses a non-writable home dir, make sure .cache is writable
ifeq ("${HOME}", "/")
Expand Down
2 changes: 1 addition & 1 deletion internal/controller/pattern_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,7 +978,7 @@ func (r *PatternReconciler) checkSpokeApplicationsGone(appOfApps bool) (bool, er
}

// Make the request
resp, err := httpClient.Do(req)
resp, err := httpClient.Do(req) //nolint:gosec // URL is constructed from a known internal service endpoint
if err != nil {
return false, fmt.Errorf("failed to make HTTP request to search service: %w", err)
}
Expand Down