refactor: use shared field-required mixin in Lumo checkbox#11749
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
web-padawan
commented
May 13, 2026
|
|
||
| :host([required]) [part='required-indicator']::after { | ||
| content: var(--vaadin-input-field-required-indicator, var(--lumo-required-field-indicator, '\2022')); | ||
| transition: opacity 0.2s; |
Member
Author
There was a problem hiding this comment.
This was copied from form-item.css but not working as in checkbox, indicator is hidden using display: none and not opacity.
| ); | ||
| width: 1em; | ||
| text-align: center; | ||
| position: static; |
Member
Author
There was a problem hiding this comment.
This is needed because in case of checkbox, the indicator itself is positioned and not ::after.
We could probably change that in the future when modifying Lumo to use base styles.
vursen
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lumo checkbox duplicated the required indicator content, color, and invalid-state color rules already provided by the shared
lumo_mixins_field-requiredmixin. Added the mixin to the checkbox and drop the duplicated declarations, keeping only the checkbox-specific position overrides.This is a finding from the
vaadin-toggle-switchprototype (which duplicated corresponding CSS from checkbox).🤖 Generated with Claude Code