chore: add performance marks to track grid row rendering#10763
Closed
chore: add performance marks to track grid row rendering#10763
Conversation
vursen
changed the title
vursen
changed the title
vursen
force-pushed
the
grid-user-timings
branch
from
76b5925 to
dede8ea
Compare
|
vursen
changed the title
Contributor
DiegoCardoso
left a comment
DiegoCardoso
left a comment
There was a problem hiding this comment.
Do you believe it is worth calling performance.clearMarks()/performance.clearMeasures() somewhere?
Contributor
Author
Good question... I'm not sure I have the answer... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds performance marks to show in the DevTools where column tree and row rendering starts and how long it takes:
Type of change