experiment: general-purpose overlay animations#10693
Closed
Conversation
jouni
force-pushed
the
experiment/base-overlay-animations
branch
3 times, most recently
from
92ba9bd to
5e0c4d3
Compare
jouni
force-pushed
the
experiment/base-overlay-animations
branch
2 times, most recently
from
bb9d538 to
816bea3
Compare
jouni
force-pushed
the
experiment/base-overlay-animations
branch
from
816bea3 to
4bcc35c
Compare
|
Member
Author
|
Getting back to it once we have the time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11321
Adds built-in keyframe animations to all overlays, which a theme can then turn on via CSS custom properties (see the changed files for examples how). For a simple fade-in/out animation, all that is needed is to define the
--animation-durationproperty on a component with an overlay.Experimented with notification animations at the same time, as they require a bit more elaborate configuration so that the stacking notifications enter and leave without all the other notifications jumping suddenly.