feat: plain Spring integration (observability-kit-spring)#331
Merged
Conversation
… observation enricher) Port Flow's vaadin-micrometer-spring into the observability-kit-spring module with package/class renames and the additional client/clientRatePerSession property bindings beyond the prototype.
…es; package-private beans and enricher)
heruan
changed the title
caalador
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #327.
Adds the
observability-kit-springmodule — plain (non-Boot) Spring integration, opt-in via@Import(ObservabilityConfiguration.class).What's included
ObservabilityConfiguration(@Configuration): bindsvaadin.observability.*via constructor injection into anObservabilitySettings, and exposes aMetricsServiceInitListenerbean. Uses a Spring-aware listener subclass that:DefaultMeterObservationHandler— avoids double Timer emission), and/vaadin/<type>,http <method> vaadin <type>) so the request type is visible on the parent HTTP span.SpringHttpObservationEnricher: best-effort lift of the Vaadin request type into Spring'sServerRequestObservationContext; no-ops without spring-web.installDefaultObservationHandlers/enrichHttpObservationhooks (added in Part 2).Notes
@Valueconstructor injection, not@ConfigurationProperties(that's a Spring Boot feature — it arrives with the starter in Part 4). No Spring Boot dependency here.ObservabilityConfigurationispublic(required so users can@Importit); its constructor, both@Beanmethods, the enricher, and the listener subclass are all package-private.client/client-rate-per-session(the prototype omitted these).mvn verifygreen (7 module tests; 111 across the reactor).Dependencies
vaadin-spring(flow-bom),spring-context,spring-web(optional); Spring Boot4.0.5BOM forspring-*version management;assertj-core+mockito-junit-jupiter(test).Out of scope
Spring Boot auto-configuration / starter + integration-test modules (Part 4, #328).