test: add it tests for micrometer core#330
Merged
Merged
Conversation
heruan
requested changes
Jun 9, 2026
heruan
left a comment
Member
There was a problem hiding this comment.
Could we move it to a profile so the unit build stays license-free, while CI (which sets the key) still runs it by default?
<profiles>
<profile>
<id>it</id>
<activation>
<property><name>!skipIt</name></property>
</activation>
<modules>
<module>observability-kit-micrometer-test</module>
</modules>
</profile>
</profiles>IT builds by default (CI keeps running it), but mvn verify -DskipIt (or building just the core modules) skips ITs. The workflow can stay as-is.
heruan
requested changes
Jun 9, 2026
add TestBench tests for the micrometer core feature.
9017ecc to
3022868
Compare
Collaborator
Author
|
Renamed and profile added |
heruan
requested changes
Jun 9, 2026
heruan
left a comment
Member
There was a problem hiding this comment.
Just noticed: I would rename the outer test module to observability-kit-test so it can include not just micrometer tests but possibly other integrations later, e.g.
- observability-kit-test-micrometer
- observability-kit-test-spring
- observability-kit-test-prometheus (e.g. docker compose, etc.)
Collaborator
Author
|
Done |
heruan
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add TestBench tests for the
micrometer core feature.