Skip to content

test: add it tests for micrometer core#330

Merged
heruan merged 4 commits into
micrometerfrom
test/add-micrometer-it-tests
Jun 9, 2026
Merged

test: add it tests for micrometer core#330
heruan merged 4 commits into
micrometerfrom
test/add-micrometer-it-tests

Conversation

@caalador

@caalador caalador commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

add TestBench tests for the
micrometer core feature.

@heruan heruan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move it to a profile so the unit build stays license-free, while CI (which sets the key) still runs it by default?

<profiles>
  <profile>
    <id>it</id>
    <activation>
      <property><name>!skipIt</name></property>
    </activation>
    <modules>
      <module>observability-kit-micrometer-test</module>
    </modules>
  </profile>
</profiles>

IT builds by default (CI keeps running it), but mvn verify -DskipIt (or building just the core modules) skips ITs. The workflow can stay as-is.

@caalador caalador force-pushed the test/add-micrometer-it-tests branch from 9017ecc to 3022868 Compare June 9, 2026 08:26
@caalador

caalador commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

Renamed and profile added

@heruan heruan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed: I would rename the outer test module to observability-kit-test so it can include not just micrometer tests but possibly other integrations later, e.g.

  • observability-kit-test-micrometer
  • observability-kit-test-spring
  • observability-kit-test-prometheus (e.g. docker compose, etc.)

@caalador

caalador commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

Done

@heruan heruan merged commit ce26dd3 into micrometer Jun 9, 2026
2 checks passed
@heruan heruan deleted the test/add-micrometer-it-tests branch June 9, 2026 08:58
@github-project-automation github-project-automation Bot moved this from 🔎Iteration reviews to Done in Vaadin Flow | Hilla | Kits ongoing work Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants