Skip to content

Replace pull_request_target with pull_request in CI workflow #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZheSun88 merged 2 commits into from
May 25, 2026
Merged

Replace pull_request_target with pull_request in CI workflow #320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82344ab
Replace pull_request_target with pull_request in CI workflow
manolo May 20, 2026
c7a05df
Merge branch 'main' into fix/remove-pull-request-target
ZheSun88 May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
push:
branches: [main]
workflow_dispatch:
pull_request_target:
pull_request:
types: [opened, synchronize, reopened]
branches: [main]
merge_group:
Expand All @@ -22,12 +22,13 @@ env:
JAVA_VERSION: '21'
jobs:
build:
environment: ${{ github.event.pull_request.head.repo.fork && 'pr-tests' || '' }}
if: ${{ !github.event.pull_request.head.repo.fork }}
timeout-minutes: 20
runs-on: ubuntu-24.04
steps:
- run: echo "Concurrency Group = ${_HEAD_REF:-$_REF_NAME}"
- name: Check secrets
if: ${{ !github.event.pull_request.head.repo.fork }}
run: |
[ -z "${{secrets.VAADIN_PRO_KEY}}" ] \
&& echo "🚫 **VAADIN_PRO_KEY** is not defined, check that **${{github.repository}}** repo has a valid secret" \
Expand Down Expand Up @@ -65,6 +66,7 @@ jobs:
path: workspace.tar
tests:
needs: build
if: ${{ !github.event.pull_request.head.repo.fork }}
timeout-minutes: 30
runs-on: ubuntu-24.04
steps:
Expand Down Expand Up @@ -120,7 +122,7 @@ jobs:
issues: read
checks: write
pull-requests: write
if: ${{ always() }}
if: ${{ always() && !github.event.pull_request.head.repo.fork }}
needs: [tests]
runs-on: ubuntu-24.04
steps:
Expand Down
Loading