feat: hierarchical menu entries based on route hierarchy#24556
Draft
Artur- wants to merge 1 commit into
Draft
Conversation
Artur-
force-pushed
the
feature/hierarchical-menu
branch
from
195a572 to
3a1983a
Compare
Artur-
force-pushed
the
feature/hierarchical-menu
branch
3 times, most recently
from
9ccb5f5 to
3a122e0
Compare
Add MenuConfiguration.getMenuEntriesTree() returning the menu views nested according to the route hierarchy instead of as a flat list. Server views are nested via RouteUtil.getRouteHierarchy (honouring @RouteParent with URL-prefix fallback) and client views via their file-system route nesting; each view attaches to its nearest included ancestor. The existing MenuEntry record gains a self-nesting List<MenuEntry> children component. An explicit no-children constructor keeps the previous 5-arg construction source- and binary-compatible, and the compact constructor normalizes children to a non-null unmodifiable list. The flat getMenuEntries() is unchanged and returns entries with empty children. The tree assembly lives in MenuRegistry.collectMenuItemsTree(), which builds directly on collectMenuItemsList(): that already normalizes routes to menu links and sorts globally, so the tree only has to resolve parents and group the already-ordered entries.
Artur-
force-pushed
the
feature/hierarchical-menu
branch
from
3a122e0 to
9f9fd70
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MenuConfiguration.getMenuEntriesTree() returning the menu views nested according to the route hierarchy instead of as a flat list. Server views are nested via RouteUtil.getRouteHierarchy (honouring @RouteParent with URL-prefix fallback) and client views via their file-system route nesting; each view attaches to its nearest included ancestor.
The existing MenuEntry record gains a self-nesting List children component. An explicit no-children constructor keeps the previous 5-arg construction source- and binary-compatible, and the compact constructor
normalizes children to a non-null unmodifiable list. The flat getMenuEntries() is unchanged and returns entries with empty children.
The tree assembly lives in MenuRegistry.collectMenuItemsTree(), which builds directly on collectMenuItemsList(): that already normalizes routes to menu links and sorts globally, so the tree only has to resolve parents and group the already-ordered entries.