Skip to content

feat: validate URL schemes in Anchor, IFrame and Page#open #24539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Artur- wants to merge 21 commits into
base: main
Choose a base branch
from
+697 −0

Merge branch 'main' into safe-url

44f202a
Select commit
Loading
Failed to load commit list.
Open

feat: validate URL schemes in Anchor, IFrame and Page#open #24539

Merge branch 'main' into safe-url
44f202a
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 11, 2026 in 34s

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 371 in flow-server/src/test/java/com/vaadin/flow/component/page/PageTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "page" which hides the field declared at line 80. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ6s_67_Q3nrFQ2KMoJZ&open=AZ6s_67_Q3nrFQ2KMoJZ&pullRequest=24539

Check warning on line 403 in flow-server/src/test/java/com/vaadin/flow/component/page/PageTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "page" which hides the field declared at line 80. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ6mJpr9UESpWalYxXtK&open=AZ6mJpr9UESpWalYxXtK&pullRequest=24539

Check warning on line 456 in flow-html-components/src/test/java/com/vaadin/flow/component/html/AnchorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ6xtmb_lrIXgwXJSwCK&open=AZ6xtmb_lrIXgwXJSwCK&pullRequest=24539

Check warning on line 385 in flow-server/src/test/java/com/vaadin/flow/component/page/PageTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "page" which hides the field declared at line 80. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ6s_67_Q3nrFQ2KMoJa&open=AZ6s_67_Q3nrFQ2KMoJa&pullRequest=24539

Check warning on line 355 in flow-server/src/test/java/com/vaadin/flow/component/page/PageTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "page" which hides the field declared at line 80. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ6mJpr9UESpWalYxXtJ&open=AZ6mJpr9UESpWalYxXtJ&pullRequest=24539

Check warning on line 424 in flow-server/src/test/java/com/vaadin/flow/component/page/PageTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "page" which hides the field declared at line 80. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ6s_67_Q3nrFQ2KMoJb&open=AZ6s_67_Q3nrFQ2KMoJb&pullRequest=24539
View more details on SonarQubeCloud