chore: add JaCoCo coverage reporting for SonarCloud#24518
Open
mshabarov wants to merge 2 commits into
Open
Conversation
Wire the jacoco-maven-plugin into the parent pom so unit tests produce
per-module target/site/jacoco/jacoco.xml reports that the Sonar scanner
reads automatically. The prepare-agent goal injects the coverage agent via
the existing ${surefire.argLine} placeholder; the report goal writes the
XML during the test phase.
vaadin-dev-server previously set surefire.argLine statically for
--add-opens, which JaCoCo now owns, so it appends the flag after
${surefire.argLine} to preserve instrumentation.
The Sonar PR workflow ran with -DskipTests and produced no coverage; it now
runs unit tests, skips integration tests (-DskipITs), and excludes the
flow-tests module (sonar.skip=true, needs a browser/TestBench license).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Artur-
requested changes
Jun 9, 2026
Artur-
left a comment
Artur-
left a comment
Member
There was a problem hiding this comment.
Wouldn't this run unit tests twice for no reason? Why not include sonar in the unit test build instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire the jacoco-maven-plugin into the parent pom so unit tests produce per-module target/site/jacoco/jacoco.xml reports that the Sonar scanner reads automatically. The prepare-agent goal injects the coverage agent via the existing ${surefire.argLine} placeholder; the report goal writes the XML during the test phase.
vaadin-dev-server previously set surefire.argLine statically for --add-opens, which JaCoCo now owns, so it appends the flag after ${surefire.argLine} to preserve instrumentation.
The Sonar PR workflow ran with -DskipTests and produced no coverage; it now runs unit tests, skips integration tests (-DskipITs), and excludes the flow-tests module (sonar.skip=true, needs a browser/TestBench license).