feat: add RouteHierarchy walker#24446
Closed
web-padawan wants to merge 1 commit into
Closed
Conversation
Introduces com.vaadin.flow.router.RouteHierarchy with resolveAncestors and resolveParent. Consumes @RouteParent first, falls back to URL-prefix walking via RouteConfiguration#getTemplate / #getRoute. Cycle-safe via a visited set. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
tltv
requested changes
Jun 9, 2026
tltv
left a comment
tltv
left a comment
Member
There was a problem hiding this comment.
I noticed that other PR added also Entry record and parameter support. Entry can be extracted to RouteHierarchyEntry record. Public resolveAncestors methods can go to RouteConfiguration, rest to RouteUtil.
| * @see RouteParent | ||
| * @see RouteConfiguration | ||
| */ | ||
| public static List<Class<? extends Component>> resolveAncestors( |
Member
There was a problem hiding this comment.
Move to RouteConfiguration class and change to non-static and remove routeConfiguration parameter.
| * @see RouteParent | ||
| * @see RouteConfiguration | ||
| */ | ||
| public static Optional<Class<? extends Component>> resolveParent( |
| * present are rejected to avoid cycles | ||
| * @return the parent class, or empty when no parent can be resolved | ||
| */ | ||
| private static Optional<Class<? extends Component>> findParent( |
| * @see RouteParent | ||
| * @see RouteConfiguration | ||
| */ | ||
| public final class RouteHierarchy { |
Member
There was a problem hiding this comment.
If everything will be moved out, remove RouteHierarchy.
Member
Author
|
Closing in favor of #24550 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds com.vaadin.flow.router.RouteHierarchy — walks ancestor routes
for a given
@Routeclass, consulting @RouteParent first and fallingback to URL-prefix walking. Cycle-safe.
Stacked on #24444 (adds @RouteParent). That PR should land first;
GitHub will auto-retarget this PR to main once it merges.
Test plan
flow-spec.md Step 3 contract
🤖 Generated with Claude Code