Replace ThemableTextField's vaadin-text-field backing with a faux element#24440
Draft
Artur- wants to merge 1 commit into
Draft
Replace ThemableTextField's vaadin-text-field backing with a faux element#24440Artur- wants to merge 1 commit into
Artur- wants to merge 1 commit into
Conversation
Test Results 1 438 files ±0 1 438 suites ±0 1h 17m 44s ⏱️ - 5m 33s For more details on these failures, see this check. Results for commit ae53af6. ± Comparison against base commit 1ac94ad. ♻️ This comment has been updated with latest results. |
…ment ThemableTextField is a test-only wrapper used by two ITs that exercise Flow's per-component CSS machinery (a CSS file at theme/components/<tag>.css, and @CssImport(themeFor=<tag>)). Both mechanisms target a specific custom-element tag name and inject styles into its shadow DOM; the actual vaadin-text-field was incidental. Drop the @NpmPackage("@vaadin/text-field") and back ThemableTextField with a small hand-rolled custom element ("themable-input") whose shadow DOM reproduces the structure the ITs walk (div.vaadin-field-container > vaadin-input-container[part=input-field]). Update the per-component CSS path in ComponentThemeLiveReloadIT and the themeFor value in vite-basics' MainView to match the new tag. Net effect: identical test coverage of Flow's per-component CSS pipeline and live-reload, without depending on a Vaadin web component. Part of removing TestVersion.VAADIN usages.
Artur-
force-pushed
the
drop-themable-text-field
branch
from
594650f to
ae53af6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThemableTextField is a test-only wrapper used by two ITs that exercise Flow's per-component CSS machinery (a CSS file at
theme/components/.css, and @CssImport(themeFor=)). Both mechanisms target a specific custom-element tag name and inject styles into its shadow DOM; the actual vaadin-text-field was incidental.
Drop the @NpmPackage("@vaadin/text-field") and back ThemableTextField with a small hand-rolled custom element ("themable-input") whose shadow DOM reproduces the structure the ITs walk (div.vaadin-field-container > vaadin-input-container[part=input-field]). Update the per-component CSS path in ComponentThemeLiveReloadIT and the themeFor value in vite-basics' MainView to match the new tag.
Net effect: identical test coverage of Flow's per-component CSS pipeline and live-reload, without depending on a Vaadin web component. Part of removing TestVersion.VAADIN usages.