Skip to content

feat: add popover opt-out configuration for loading indicator#24398

Open
platosha wants to merge 2 commits into
mainfrom
feat/connection-indicator-popover-opt-out
Open

feat: add popover opt-out configuration for loading indicator#24398
platosha wants to merge 2 commits into
mainfrom
feat/connection-indicator-popover-opt-out

Conversation

@platosha

Copy link
Copy Markdown
Contributor

Fixes #24072
Depends on vaadin/flow-hilla-common#26

  • Add Popover opt-out property with default value (false)
  • Implement listener for popover opt-out changes
  • Update ConfigurationMap to support the new setting
  • Add getter/setter methods in LoadingIndicatorConfiguration.java
  • Include test cases for popover opt-out functionality

Fixes #24072
Depends on vaadin/flow-hilla-common#26

- Add Popover opt-out property with default value (false)
- Implement listener for popover opt-out changes
- Update ConfigurationMap to support the new setting
- Add getter/setter methods in LoadingIndicatorConfiguration.java
- Include test cases for popover opt-out functionality
@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown

Test Results

 1 410 files   -   3   1 410 suites   - 3   1h 20m 36s ⏱️ - 1m 30s
10 161 tests +179  10 092 ✅ +179  69 💤 ±0  0 ❌ ±0 
10 636 runs  +179  10 565 ✅ +179  71 💤 ±0  0 ❌ ±0 

Results for commit 2fe57b3. ± Comparison against base commit b559b92.

♻️ This comment has been updated with latest results.

@mshabarov mshabarov self-requested a review May 25, 2026 11:51
@sonarqubecloud

sonarqubecloud Bot commented Jun 1, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 🔎Iteration reviews

Development

Successfully merging this pull request may close these issues.

vaadin-connection-indicator sets popover="manual" causing status message flicker and incorrect positioning

1 participant