chore: cache charts SVG generator output across CI runs#9488
Open
sissbruecker wants to merge 1 commit into
Open
chore: cache charts SVG generator output across CI runs#9488sissbruecker wants to merge 1 commit into
sissbruecker wants to merge 1 commit into
Conversation
The build cache key includes the run id and never hits across runs, so the SVG generator's npm install + webpack build + mocha tests ran on every Build job (~40s). This change caches the generated output keyed on the module sources and skips the npm build / test on a hit via -DskipSvgChartsBuild. This should be fine as there is no need to build / test again unless any of the sources change, in contrast to the main build which always needs to re-run due to potential snapshot dependency changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build cache key includes the run id and never hits across runs, so the SVG generator's npm install + webpack build + mocha tests ran on every Build job (~40s).
This change caches the generated output keyed on the module sources and skips the npm build / test on a hit via -DskipSvgChartsBuild. This should be fine as there is no need to build / test again unless any of the sources change, in contrast to the main build which always needs to re-run due to potential snapshot dependency changes.