You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Dashboard assets are bundled during startup using esbuild and served from cache.
This approach does not introduce an additional build step, keeping the installation process the same as usual.
Bundling and serving all our own dependencies has two main benefits:
Everything can be downloaded over one connection.
Previously, the dashboard needed over 600 requests to load, due to the nature of the date-fns package and esm.sh's behaviour. This is no longer the case.
Prior caching behaviour is maintained by moving the dynamic state into an inline script in the main HTML file. Scripts and fonts are cached for a long time.
I'm not dead set on getting this merged, but I think it does improve things overall.
Previously, the dashboard needed over 600 requests to load, due to the nature of the date-fns package and esm.sh's behaviour. This is no longer the case.
can you not combine ?exports with ?bundle? these options would make esm.sh bundle all files and tree shake that server side.
can you not combine ?exports with ?bundle? these options would make esm.sh bundle all files and tree shake that server side.
Nope, that doesn't work. They've since shuffled flags around a bit, but regardless, they don't support bundling things in cases like date-fns where every function receives its own export. Doing so could subtly break things is their reasoning, they're not wrong, but in this case that isn't the case of course.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashboard assets are bundled during startup using esbuild and served from cache.
This approach does not introduce an additional build step, keeping the installation process the same as usual.
Bundling and serving all our own dependencies has two main benefits:
date-fnspackage and esm.sh's behaviour. This is no longer the case.Prior caching behaviour is maintained by moving the dynamic state into an inline script in the main HTML file. Scripts and fonts are cached for a long time.
I'm not dead set on getting this merged, but I think it does improve things overall.