Add option to choose encoding for non-ASCII atoms (latin1 or utf8)#41
Open
seriyps wants to merge 2 commits intouwiger:masterfrom
Open
Add option to choose encoding for non-ASCII atoms (latin1 or utf8)#41seriyps wants to merge 2 commits intouwiger:masterfrom
seriyps wants to merge 2 commits intouwiger:masterfrom
Conversation
Owner
|
I think you need to handle the code being called with a (legacy) |
Author
|
Done, good point! |
Owner
|
Thanks. Will try to test this during the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the #40
However it doesn't add support to
encode_prefix/decode_prefix, mainly becauseLegacyoption was not supported there as well. However I think I should actually add it. Maybe separate commit?Readme should be probably updated as well.
I didn't run tests because I don't have quickcheck, but it compiles and seems to work:
So, what do you think?