Alternative prev_click_rank() and get_last_click_rank() implementation.#1
Open
skip-th wants to merge 1 commit intouva-sne:mainfrom
Open
Alternative prev_click_rank() and get_last_click_rank() implementation.#1skip-th wants to merge 1 commit intouva-sne:mainfrom
skip-th wants to merge 1 commit intouva-sne:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplemented get_last_click_rank() and prev_click_rank(). In get_last_click_rank(), iterate backward through the search results, which allows you to stop early if the last click was not on the first search result. In prev_click_rank(), replaced the double loop with a single loop over all search results.