Skip to content

Stabilize some benchmarks#13254

Open
sylvestre wants to merge 3 commits into
uutils:mainfrom
sylvestre:sort_ascii_c_locale
Open

Stabilize some benchmarks#13254
sylvestre wants to merge 3 commits into
uutils:mainfrom
sylvestre:sort_ascii_c_locale

Conversation

@sylvestre

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/misc/sync. tests/misc/sync is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout-group (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

@codspeed-hq

codspeed-hq Bot commented Jul 2, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 97.21%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 4 regressed benchmarks
✅ 327 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation sort_ascii_c_locale 16.7 ms 1,720.9 ms -99.03%
Simulation sort_ascii_utf8_locale 16.1 ms 1,273.9 ms -98.73%
Memory sort_ascii_c_locale 4.6 MB 81.8 MB -94.37%
Memory sort_ascii_utf8_locale 4.6 MB 52.4 MB -91.21%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing sylvestre:sort_ascii_c_locale (b2e47da) with main (51529dc)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@cakebaker

Copy link
Copy Markdown
Contributor

The TOML job fails with:

Warning: Defining tables out-of-order is discouraged
    at ./src/uu/df/Cargo.toml:28:1
Warning: Defining tables out-of-order is discouraged
    at ./src/uu/df/Cargo.toml:36:1

@sylvestre sylvestre force-pushed the sort_ascii_c_locale branch from bd64bcb to b2e47da Compare July 4, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants