Skip to content

fix(factor): Correct comment #13226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HackingRepo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(factor): Correct comment #13226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffd8b5c
fix(factor): Correct comment
HackingRepo Jun 30, 2026
4834c02
Fix review issues
HackingRepo Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/uu/factor/src/factor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
let print_exponents = matches.get_flag(options::EXPONENTS);

let stdout = stdout();
// We use a smaller buffer here to pass a gnu test. 4KiB appears to be the default pipe size for bash.
// use a smaller buffer here to pass a GNU test.
let mut w = io::BufWriter::with_capacity(4 * 1024, stdout.lock());

@oech3 oech3 Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't know why is this size needed. Perhaps, https://doc.qu1x.dev/bevy_trackball/rustix/pipe/constant.PIPE_BUF.html ?
(I did not test that the const is usable on non unix.)


if let Some(values) = matches.get_many::<String>(options::NUMBER) {
Expand Down
Loading