Skip to content

locale: fix incomplete fallback bundles#11855

Closed
BAMF0 wants to merge 0 commit into
uutils:mainfrom
BAMF0:main
Closed

locale: fix incomplete fallback bundles#11855
BAMF0 wants to merge 0 commit into
uutils:mainfrom
BAMF0:main

Conversation

@BAMF0

@BAMF0 BAMF0 commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Fix an error where only the common strings would be used when falling back to embedded locales. This lead to an issue where the raw Fluent message keys were returned rather than actual error messages, such as wc-error-failed-to-print-result instead of "failed to print result".

Additionally, preserve partial resources instead of discarding everything when not all messages could be parsed.

Fixes #11854

@github-actions

github-actions Bot commented Apr 16, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.

@codspeed-hq

codspeed-hq Bot commented Apr 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 331 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing BAMF0:main (cb82979) with main (df0701c)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@xtqqczze

This comment was marked as outdated.

@xtqqczze

This comment was marked as outdated.

@BAMF0

BAMF0 commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

Hmm the French tests seem to be failing unfortunately. They pass on my machine, I will have a look as to why.

@BAMF0

BAMF0 commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

Ah nevermind, the failing utility (hostid) does not have a french translation available under src/uu/hostid/locales, only en-US.ftl.

@BAMF0

BAMF0 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #13257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

locale: incomplete locale bundles when utility-specific locale files fail to load

2 participants