Skip to content

unexpand: use buffered read#10798

Open
cerdelen wants to merge 1 commit intouutils:mainfrom
cerdelen:unexpand_buffer
Open

unexpand: use buffered read#10798
cerdelen wants to merge 1 commit intouutils:mainfrom
cerdelen:unexpand_buffer

Conversation

@cerdelen
Copy link
Contributor

@cerdelen cerdelen commented Feb 7, 2026

Changing from using read_until to read() and necessary additions to the unexpand_line function to keep behaviour.

Fix: #10698

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 7, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 34.66%

Comparing cerdelen:unexpand_buffer (f1f58b8) with main (dc982b1)

Summary

⚡ 2 improved benchmarks
✅ 282 untouched benchmarks
⏩ 38 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation unexpand_many_lines[100000] 263.6 ms 195.8 ms +34.64%
Simulation unexpand_large_file[10] 552.6 ms 410.4 ms +34.66%

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unexpand: unexpand /dev/zero panic

1 participant