perf(nl): reuse itoa buffer for line numbering#10796
Closed
CrazyRoka wants to merge 1 commit intouutils:mainfrom
Closed
perf(nl): reuse itoa buffer for line numbering#10796CrazyRoka wants to merge 1 commit intouutils:mainfrom
CrazyRoka wants to merge 1 commit intouutils:mainfrom
Conversation
Contributor
|
The documentation for |
|
GNU testsuite comparison: |
Contributor
Author
|
Right, I see no improvement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid re-allocating an
itoa::Bufferfor every line processed. By lifting the buffer creation out of theformat_tofunction, we reduce memory pressure and improve performance when processing large files.