Sort: bench ahash by oech3 · Pull Request #10783 · uutils/coreutils

oech3 · 2026-02-07T11:29:38Z

No description provided.

codspeed-hq · 2026-02-07T11:37:49Z

Merging this PR will improve performance by 13.34%

⚡ 5 improved benchmarks
✅ 279 untouched benchmarks
⏩ 38 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Simulation	`sort_dictionary_order[500000]`	1.1 s	1 s	+9.79%
⚡	Simulation	`sort_numeric[500000]`	1.2 s	1 s	+13.34%
⚡	Simulation	`sort_general_numeric[200000]`	721.1 ms	659.5 ms	+9.33%
⚡	Simulation	`sort_key_field[500000]`	853.4 ms	783.2 ms	+8.96%
⚡	Simulation	`sort_case_insensitive[500000]`	257.2 ms	249 ms	+3.28%

_{Comparing oech3:sort-ahash (970f6b2) with main (3d56517)}

38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

sylvestre · 2026-02-07T11:42:37Z

.github/workflows/benchmarks.yml

-          uu_wc,
-          uu_factor,
-          uu_date
+          uu_sort


why do you remove them ? it isn't helping much ?!

Useful to call codspeed quickly.

src/uu/sort/Cargo.toml

sylvestre · 2026-02-07T11:43:38Z

Merging this PR will improve performance by 14.56%

impressive!

xtqqczze · 2026-02-07T11:47:35Z

Merging this PR will improve performance by 14.56%

Interesting, using rustc-hash showed no change in #10690

oech3 · 2026-02-07T11:49:15Z

Interesting, using rustc-hash showed no change in

Because I kept 1 Fnv to unbreak sort -R. I will test rustc-hash at internal Hash* (non-RNG part).

oech3 · 2026-02-07T11:56:01Z

Also we reciently applied codegen-units=1 to release profile.
So previous 9.* % is not used for comparison.

xtqqczze · 2026-02-07T11:59:27Z

it's probably worth trying foldhash as well?

sylvestre · 2026-02-07T12:29:48Z

src/uu/sort/src/sort.rs

 use std::ffi::{OsStr, OsString};
 use std::fs::{File, OpenOptions};
-use std::hash::{Hash, Hasher};
+use std::hash::BuildHasher as _;


why "as _" ?

to avoid confliction in the future.

Applying clippy removed it...

i would prefer we don't have this
it is a pretty ugly in the code base
i would prefer you remove the " as " in use ahash::AHashMap as HashMap;
instead
and change the name
it isn't like we are going not change the hashmap on a regular basis

@xtqqczze recommended shadowing. Should we revert also for other utils?

I switched to AHash* at here anyway.

yes, i don't like shadowing

github-actions · 2026-02-07T12:36:20Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

github-actions · 2026-02-07T12:54:09Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

github-actions · 2026-02-07T13:36:29Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/follow-name (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

github-actions · 2026-02-07T14:50:44Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

sylvestre reviewed Feb 7, 2026

View reviewed changes

src/uu/sort/Cargo.toml Outdated Show resolved Hide resolved

oech3 force-pushed the sort-ahash branch 6 times, most recently from b4aa98b to bd12116 Compare February 7, 2026 12:26

sylvestre reviewed Feb 7, 2026

View reviewed changes

oech3 force-pushed the sort-ahash branch from bd12116 to 7f34f68 Compare February 7, 2026 12:44

oech3 force-pushed the sort-ahash branch from 7f34f68 to c1ae33a Compare February 7, 2026 13:02

oech3 force-pushed the sort-ahash branch from c1ae33a to 970f6b2 Compare February 7, 2026 14:37

oech3 marked this pull request as ready for review February 7, 2026 14:37

sort: Use ahash

ce5362d

sylvestre force-pushed the sort-ahash branch from 970f6b2 to ce5362d Compare February 7, 2026 16:05

Uh oh!

Conversation

oech3 commented Feb 7, 2026

Uh oh!

codspeed-hq bot commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 13.34%

Performance Changes

Footnotes

Uh oh!

sylvestre Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

oech3 Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sylvestre commented Feb 7, 2026

Uh oh!

xtqqczze commented Feb 7, 2026

Uh oh!

oech3 commented Feb 7, 2026

Uh oh!

oech3 commented Feb 7, 2026

Uh oh!

xtqqczze commented Feb 7, 2026

Uh oh!

sylvestre Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

oech3 Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

oech3 Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

sylvestre Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

oech3 Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sylvestre Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 7, 2026

Uh oh!

github-actions bot commented Feb 7, 2026

Uh oh!

github-actions bot commented Feb 7, 2026

Uh oh!

github-actions bot commented Feb 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codspeed-hq bot commented Feb 7, 2026 •

edited

Loading

oech3 Feb 7, 2026 •

edited

Loading