Skip to content

shuf; Drop inline after switched to fxhash#10781

Merged
sylvestre merged 1 commit intouutils:mainfrom
oech3:shuf-inline
Feb 7, 2026
Merged

shuf; Drop inline after switched to fxhash#10781
sylvestre merged 1 commit intouutils:mainfrom
oech3:shuf-inline

Conversation

@oech3
Copy link
Contributor

@oech3 oech3 commented Feb 7, 2026

fxhash might changed nstructions,cycles,L1-icache-load-misses,branches,branch-misses

@oech3 oech3 marked this pull request as ready for review February 7, 2026 06:17
@github-actions
Copy link

github-actions bot commented Feb 7, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/tail/symlink is no longer failing!

@sylvestre
Copy link
Contributor

fxhash might changed nstructions,cycles,L1-icache-load-misses,branches,branch-misses

sorry, i don't understand this message and how it is related with inline

@oech3
Copy link
Contributor Author

oech3 commented Feb 7, 2026

inline(never) was added to avoid performance regression with codegen-units=1 (improve cache hit and branch-misses).
Also switching to fxhash also improved them. So I considered that we achieved enough cache to inline shuf_exec again for perf.

But it seems useful only for cleaning code currently https://codspeed.io/uutils/coreutils/branches/oech3%3Ashuf-inline?utm_source=github&utm_medium=check&utm_content=button&q=shuf

@sylvestre sylvestre merged commit bcb890b into uutils:main Feb 7, 2026
151 of 152 checks passed
@oech3 oech3 deleted the shuf-inline branch February 7, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants