Skip to content

Add rust-version field to all Cargo.toml files#10778

Merged
cakebaker merged 1 commit intouutils:mainfrom
xtqqczze:rust-version
Feb 7, 2026
Merged

Add rust-version field to all Cargo.toml files#10778
cakebaker merged 1 commit intouutils:mainfrom
xtqqczze:rust-version

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Feb 6, 2026

This is necessary to prevent Clippy from producing incorrect suggestions.

@xtqqczze xtqqczze changed the title Add rust-version field to all Cargo.toml files in the project Add rust-version field to all Cargo.toml files Feb 7, 2026
@xtqqczze xtqqczze marked this pull request as ready for review February 7, 2026 03:59
@github-actions
Copy link

github-actions bot commented Feb 7, 2026

GNU testsuite comparison:

GNU test failed: tests/tail/truncate. tests/tail/truncate is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/tail/retry is no longer failing!

@cakebaker
Copy link
Contributor

Why not set msrv in .clippy.toml? For some reason it got removed with the recent update of the MSRV.

@oech3
Copy link
Contributor

oech3 commented Feb 7, 2026

I don't think .clippy.toml work as @cakebaker assumed. clippy still produced a bunch of wanings before this discussion.

@oech3
Copy link
Contributor

oech3 commented Feb 7, 2026

Does not this PR remove clippy::manual_is_multiple_of config?

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Feb 7, 2026

Why not set msrv in .clippy.toml? For some reason it got removed with the recent update of the MSRV.

The incorrect suggestions are in fact caused by the removal of msrv from .clippy.toml.

I initially thought this was no longer necessary because we specify rust-version in Cargo.toml, but that setting wasn’t applied at the workspace level as I had assumed.

Even so, I still think this is the better approach.

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Feb 7, 2026

Does not this PR remove clippy::manual_is_multiple_of config?

manual_is_multiple_of isn't affected; it is correct for clippy to make the suggestions because unsigned_is_multiple_of is a 1.87 feature.

@cakebaker cakebaker merged commit 3d56517 into uutils:main Feb 7, 2026
153 of 156 checks passed
@cakebaker
Copy link
Contributor

Thanks!

@xtqqczze xtqqczze deleted the rust-version branch February 7, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants