Open
Conversation
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
ChrisDryden
reviewed
Feb 6, 2026
| 125, | ||
| translate!("nice-error-command-required-with-adjustment"), | ||
| )); | ||
| let _ = writeln!( |
Collaborator
There was a problem hiding this comment.
I'm a bit suspicious that this is the right place to do it?
I'm curious if you think that it would be possible to fix this in the procs lib at:
src/uucore_procs/src/lib.rs:59
Contributor
Author
There was a problem hiding this comment.
looks more generic (if possible).
oech3
commented
Feb 6, 2026
| // We can't use `show_warning` because that will panic if stderr | ||
| // isn't writable. The GNU test suite checks specifically that the | ||
| // exit code when failing to write the advisory is 125, but Rust | ||
| // will produce an exit code of 101 when it panics. |
Contributor
Author
There was a problem hiding this comment.
We should cleanup this too.
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10747 . Removes Try
--helpmessage which matches with gnu 9.10.