perf(nl): optimize line numbering by using itoa and direct writing#10757
Merged
ChrisDryden merged 3 commits intouutils:mainfrom Feb 6, 2026
Merged
perf(nl): optimize line numbering by using itoa and direct writing#10757ChrisDryden merged 3 commits intouutils:mainfrom
ChrisDryden merged 3 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
Merging this PR will improve performance by ×2.2
Performance Changes
Comparing Footnotes
|
Collaborator
|
Some of the test failures were because of a broken main, rebasing it |
|
GNU testsuite comparison: |
ChrisDryden
reviewed
Feb 6, 2026
| } | ||
| Self::RightZero if number < 0 => { | ||
| writer.write_all(b"-")?; | ||
| let num = buffer.format(number.abs()); |
Collaborator
There was a problem hiding this comment.
Can you used unsigned_abs? I think this can cause a panic
Collaborator
There was a problem hiding this comment.
Actually this is unrelated to the original change and was already there lgtm
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the
nlcommand's performance by refactoring how line numbers are formatted and written. Previously, the code used theformat!macro for every line, which involves heap allocations and runtime parsing of format strings.By integrating the
itoacrate and writing directly to the outputBufWriter, we significantly reduce the overhead per line.