Merged
Conversation
xtqqczze
reviewed
Feb 5, 2026
| let mut second_done = false; // for when we use crown or tagged mode | ||
| loop { | ||
| while let Some(Line::FormatLine(fl)) = self.lines.peek() { | ||
| // peek ahead |
Contributor
Author
There was a problem hiding this comment.
@xtqqczze i wasn't sure if the comment is still relevant - should i just rcemove it?
Contributor
There was a problem hiding this comment.
- "peek ahead" seems pointless
- "need to explicitly force fl out of scope before we can call self.lines.next()" is incorrect because
flis in fact in scope when we callnext(), it seems a refactoring in 01c32a5 put it in scope.
cc: @tertsdiepraam
Contributor
|
which lints have been fixed and are they already enabled? if so how are they getting through CI? |
Contributor
does this behave differently to |
|
GNU testsuite comparison: |
Contributor
Author
no, exactly the same way - except that i used the version of clippy that hasn't even been included into the nightly :) |
Contributor
|
@nyurik You should make sure to use |
I ran this locally, using current main version of clippy: ```bash cargo dev lint path/to/coreutils -- --workspace --all-features ```
|
GNU testsuite comparison: |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran this locally, using current main version of clippy: