refactor: inline format! args in a few places

[nyurik]

• in one spot remove redundant mem alloc

[ChrisDryden]

I was trying to do some research into why this couldn't be enabled as a clippy rule so that this can be applied going forward and I think I was able to replicate the changes with uninlined_format_args = "warn" in Cargo.toml and adding allow-mixed-uninlined-format-args = false in the .clippy.toml

This change already brings it down from 20 to 3, I'm curious if there was something used to generate this or this was just through reading of the codebase?

[ChrisDryden]

For future reference this was the redundant memory allocation

[nyurik]

sadly no - just did a late night regex search :) I tried the lint approach at first, but it was not working for me for some reason - I figured it was due to features or specifics of the platform (i'm on linux)... And yes, i think we should add the clippy setting - i'll do it.

[nyurik]

ah yes, one other thing -- format!-like macros like show_error! may not be caught unless they have a #[clippy::format_args] attribute... but sadly there is a rustc compiler bug that breaks compilation when using an attribute on an exported macro in some cases... So for those, manual search is still the only option

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

[nyurik]

P.S. I tried to fix the compiler bug with rust-lang/rust#152190 -- if merged, in 3 months we can have all format-like macros auto-fixed by clippy

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

[xtqqczze]

ci breakage again, conflicts with 181b247

  error: variables can be used directly in the `format!` string
     --> tests/by-util/test_stdbuf.rs:106:5
      |
  106 | /     assert!(
  107 | |         loaded_from_exe_dir,
  108 | |         "libstdbuf should be loaded from exe directory ({}), not from LIBSTDBUF_DIR. LD_DEBUG output:\n{}",
  109 | |         temp_path.display(),
  110 | |         stderr
  111 | |     );
      | |_____^
      |
      = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
      = note: `-D clippy::uninlined-format-args` implied by `-D warnings`
      = help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`

[nyurik]

I wonder if CI can be stabilized somehow - rust project has far larger number of changes and yet the code tends to be more stable. The lowest hanging fruit might be to have early "tidy" warnings - so that each CI run reports fmt/clippy issues much within a few minutes of the commit?

[xtqqczze]

I wonder if CI can be stabilized somehow

The usual way to solve this problem is with a merge queue.