stdbuf: support libstdbuf in same directory as stdbuf#10352
stdbuf: support libstdbuf in same directory as stdbuf#10352sylvestre merged 1 commit intouutils:mainfrom
Conversation
|
Unfortunately, Cygwin (windows) does not allow symlink by default. Would you disable tests on Cygwin? |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
Which test is failing on Cygwin? test_stdbuf_search_order_exe_dir_first ? |
|
Cygwin package does not run test currently, but CI would not allow all of tests creating symlink. |
The test I am adding does not create a symlink, so it is not clear to me what you are asking me to do. |
Does it means tester should manually create a symlink? |
The build system creates a symlink, and would print a warning on cygwin if the command to create the symlink fails. |
Thats fine for me! |
694448a to
5f7aac1
Compare
5f7aac1 to
7bd4c53
Compare
|
GNU testsuite comparison: |
Make stdbuf search for libstdbuf first in the directory where stdbuf is running. This matches GNU coreutils behavior. Add a symlink to deps/libstdbuf in order to make it easier to run the stdbuf tests with feat_external_stdbuf enabled. Remove tests which are assuming that libstdbuf is not found. Those tests are now always failing, because the build directory contains a symlink to deps/libstdbuf and libstdbuf is always found. Fixes uutils#10345 Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
7bd4c53 to
0a95c2f
Compare
|
GNU testsuite comparison: |
|
@RenjiSann @sylvestre ping |
|
Needs this PR to publish |
Make stdbuf search for libstdbuf first in the directory where stdbuf is running. This matches GNU coreutils behavior. Add a symlink to deps/libstdbuf in order to make it easier to run the stdbuf tests with feat_external_stdbuf enabled.
Remove tests which are assuming that libstdbuf is not found. Those tests are now always failing, because the build directory contains a symlink to deps/libstdbuf and libstdbuf is always found.
Fixes #10345