Add end-to-end response streaming via streamRequest()#2
Merged
Conversation
Add streamRequest(RequestInterface, callable $sink) to the Adapter interface, the Client wrapper, and both transports. It delivers the response body to the sink chunk-by-chunk as it arrives, keeping memory bounded regardless of body size; the returned response carries the status and headers with an empty body. Both adapters use their native push mechanism in the calling context — no curl_multi, no child coroutine: - cURL forwards CURLOPT_WRITEFUNCTION to the sink (sendRequest and streamRequest now share a transfer() core). - Swoole forwards write_func to the sink in the main coroutine (sendRequest/streamRequest share perform()). sendRequest() is unchanged: still PSR-18, buffered, decodable. Tests (shared AdapterContract, so proven on curl and Swoole): - stream a body to a sink, asserting incremental delivery - 8 MiB request and response payloads round-trip; the streamed response holds peak memory under 2 MiB - redirects are not followed when streaming The test server now runs with post_max_size=64M/memory_limit=256M so large request payloads are accepted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add streamRequest(RequestInterface, callable $sink) to the Adapter interface, the Client wrapper, and both transports. It delivers the response body to the sink chunk-by-chunk as it arrives, keeping memory bounded regardless of body size; the returned response carries the status and headers with an empty body.
Both adapters use their native push mechanism in the calling context — no curl_multi, no child coroutine:
sendRequest() is unchanged: still PSR-18, buffered, decodable.
Tests (shared AdapterContract, so proven on curl and Swoole):