Rename cacheKey option to key#3
Merged
Merged
Conversation
Greptile SummaryThis PR performs a mechanical rename of the
Confidence Score: 5/5Pure rename with no logic changes — safe to merge. Every call site, test, doc example, and template that referenced cacheKey has been updated to key. The rename is complete and internally consistent across all nine changed files, with the existing test suite providing good coverage of the renamed parameter. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "Rename cacheKey option to key" | Re-trigger Greptile |
e1ff51d to
a084d62
Compare
lohanidamodar
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the shared-state constructor option from
cacheKeytokey.This updates:
CircuitBreaker::__construct()named argument and internal propertycircuit_breaker.namesourceWhy
keyis shorter and matches the cache PR usage while still describing the circuit breaker state namespace.Testing
composer formatcomposer lintcomposer test:unitphp -d memory_limit=512M vendor/bin/phpstan analyseNote: plain
composer checkhit the local default 128 MB PHP memory limit, so PHPStan was rerun directly withmemory_limit=512M.