Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/CircuitBreaker/CircuitBreaker.php
Original file line number Diff line number Diff line change
Expand Up @@ -404,4 +404,15 @@ public function isHalfOpen(): bool
{
return $this->getState() === CircuitState::HALF_OPEN;
}

/**
* Force the breaker into the open state. Idempotent: re-tripping refreshes
* openedAt and re-emits gauges, but does not record a transition.
*/
public function trip(): void
{
$this->syncFromCache();
$this->transitionToOpen();
$this->recordState();
}
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Comment thread
greptile-apps[bot] marked this conversation as resolved.
}
61 changes: 61 additions & 0 deletions tests/unit/CircuitBreakerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,67 @@ public function testRejectsEmptyCacheKeyWhenCacheIsConfigured(): void
new CircuitBreaker(cache: $this->createArrayAdapter(), cacheKey: '');
}

public function testTripTransitionsToOpen(): void
{
$breaker = new CircuitBreaker();

self::assertSame(CircuitState::CLOSED, $breaker->getState());

$breaker->trip();

self::assertSame(CircuitState::OPEN, $breaker->getState());
self::assertTrue($breaker->isOpen());
}

public function testTrippedBreakerShortCircuitsCalls(): void
{
$breaker = new CircuitBreaker(threshold: 100, timeout: 30, successThreshold: 1);
$breaker->trip();

$result = $breaker->call(
open: static fn () => 'fallback',
close: function (): void {
self::fail('Closed callback should not run when the breaker has been tripped.');
}
);

self::assertSame('fallback', $result);
self::assertTrue($breaker->isOpen());
}

public function testTripIsIdempotent(): void
{
$breaker = new CircuitBreaker();

$breaker->trip();
$breaker->trip();
$breaker->trip();

self::assertSame(CircuitState::OPEN, $breaker->getState());
}

public function testTripPersistsStateThroughCacheAdapter(): void
{
$cache = $this->createArrayAdapter();
$first = new CircuitBreaker(cache: $cache, cacheKey: 'users-api');
$first->trip();

$second = new CircuitBreaker(cache: $cache, cacheKey: 'users-api');

self::assertTrue($second->isOpen());
}

public function testTripEmitsTransitionTelemetry(): void
{
$telemetry = new TestTelemetry();
$breaker = new CircuitBreaker(telemetry: $telemetry);

$breaker->trip();

self::assertSame([1], $telemetry->counters['breaker.transitions']->values);
self::assertSame([1], $telemetry->gauges['breaker.state']->values);
}

private function createArrayAdapter(): Adapter
{
return new class () implements Adapter {
Expand Down
Loading