fix(lib): null check ordering in invite validation flow #641
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The invite validation logic checked
invitingProfilefor null after usinginvitingProfileIdin subsequent validations, creating a potential null reference path ifitemsApi.getItem()returned null.Changes
invitingProfilenull check immediately after fetch, before self-invite and already-following checksBefore
After
This ensures the profile exists before downstream validation logic executes.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.