test : added unit tests for get_delivery_configuration in notification_service#1709
Open
tmdeveloper007 wants to merge 1 commit into
Open
test : added unit tests for get_delivery_configuration in notification_service#1709tmdeveloper007 wants to merge 1 commit into
tmdeveloper007 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1706.
Summary of What Has Been Done:
Added
testing/backend/unit/test_notification_service_delivery_config.pywith 7 unit tests coveringget_delivery_configurationinbackend/secuscan/notification_service.py.Changes Made:
test_returns_expected_keys: verifies all 4 required keys are presenttest_webhook_timeout_is_positive_number: webhook_timeout_seconds is a positive numbertest_webhook_connect_timeout_is_positive_number: webhook_connect_timeout_seconds is a positive numbertest_max_retries_is_zero: max_retries equals 0test_backoff_factor_is_zero: backoff_factor_seconds equals 0.0test_returns_new_dict_each_call: each call returns an independent dict (no shared mutable state)test_timeout_values_are_reasonable: timeout values are < 300sImpact it Made:
Note: This task is being handled by tmdeveloper007 — please assign to that account when picking it up.