Skip to content

Conversation

@joshuatam
Copy link
Contributor

@joshuatam joshuatam commented Jan 25, 2026

This reverts commit 15ba1bf.

The denuvo preset is unnecessary as running P5R in Compatibilty with Proton 9 x86_64 already gives the maximum performance and devuno compatibility.


Summary by cubic

Remove the Denuvo preset from Box86/64. Proton 9 x86_64 in Compatibility mode already provides the needed performance and Denuvo support (e.g., P5R), so the preset was redundant.

  • Refactors
    • Deleted Box86_64Preset.DENUVO and its env var handling in Box86_64PresetManager.
    • Removed the "Denuvo" option from the preset list.
    • Cleaned up localized strings across all languages.

Written for commit 29951ed. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Removed Denuvo preset configuration and localization strings from all supported languages.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 25, 2026

📝 Walkthrough

Walkthrough

This PR removes the DENUVO preset from the application. The constant definition, environment variable configuration, and all localized string resources for DENUVO are deleted across Java source files and multiple localization strings.xml files.

Changes

Cohort / File(s) Summary
Java Source - Preset Removal
app/src/main/java/com/winlator/box86_64/Box86_64Preset.java, app/src/main/java/com/winlator/box86_64/Box86_64PresetManager.java
Removed DENUVO constant declaration and eliminated all DENUVO-specific configuration branches including DYNAREC options (SAFEFLAGS, NAN, ROUND, X87DOUBLE, BIGBLOCK, STRONGMEM, FORWARD, CALLRET, WAIT) from environment variable generation and preset listing.
String Resources - Localization
app/src/main/res/values*/strings.xml (da, de, fr, it, pt-rBR, ro, uk, zh-rCN, zh-rTW, and base values)
Removed "denuvo" string resource entries from all locale-specific and base string resource files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • PR #432: Inverse PR that adds the DENUVO preset, constant, and localized strings—directly opposite changes to the same files and resources.
  • PR #230: Modifies the same preset manager and preset classes (Box86_64Preset and Box86_64PresetManager) to add alternative presets (UNITY/UNITY_MONO).

Poem

🐰 A preset once called Denuvo takes flight,
Removed from the code, now out of sight,
Constants and strings bid farewell with grace,
Cleaning the codebase, removing its trace! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly and specifically describes the main change: reverting a previous commit that added Denuvo preset support, which aligns with all file modifications removing Denuvo references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant