-
Notifications
You must be signed in to change notification settings - Fork 84
Improves download and decompression performance #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Improves download and decompression performance #425
Conversation
📝 WalkthroughWalkthroughUpdated JavaSteam dependency to 1.8.0-10-SNAPSHOT in build config and version catalog. Increased download/decompress ratios for speed tiers and removed the maxFileWrites variable and its DepotDownloader constructor argument; logging adjusted accordingly. Changes
Sequence Diagram(s)(omitted — changes do not introduce a new multi-component control flow that requires visualization) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 3 files
app/build.gradle.kts
Outdated
| implementation(files("../../JavaSteam/build/libs/javasteam-1.8.0-9-SNAPSHOT.jar")) | ||
| implementation(files("../../JavaSteam/javasteam-depotdownloader/build/libs/javasteam-depotdownloader-1.8.0-9-SNAPSHOT.jar")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what was changed? My download for Nidhogg is not even starting, it's stuck on "Calculating..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm, it took a minute but it started downloading eventually... Will try on a larger game
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nidhogg download still stopping at 100% and never completing, that's why we had downgraded to old version...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it eventually finished after a long delay 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are still getting the "Requested exe is invalid" error. I think something is broken...
Updates JavaSteam version, download and decompress ratios to improve download performance
7ff77a3 to
34d0668
Compare
Updates JavaSteam version, download and decompress ratios to improve download performance
Related change to JavaSteam:
joshuatam/JavaSteam@21bd4db
Summary by cubic
Improves depot download performance by tuning concurrency and upgrading to JavaSteam 1.8.0-10. This better uses CPU cores and reduces install time on faster connections.
Performance
Dependencies
Written for commit 34d0668. Summary will update on new commits.
Summary by CodeRabbit
Chores
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.