Skip to content

Conversation

@joshuatam
Copy link
Contributor

@joshuatam joshuatam commented Jan 20, 2026

Updates JavaSteam version, download and decompress ratios to improve download performance

Related change to JavaSteam:
joshuatam/JavaSteam@21bd4db


Summary by cubic

Improves depot download performance by tuning concurrency and upgrading to JavaSteam 1.8.0-10. This better uses CPU cores and reduces install time on faster connections.

  • Performance

    • Increased downloadRatio to 0.6/1.2/1.5/2.4 and tuned decompressRatio to 0.2/0.4/0.5/0.8 for speed tiers 8/16/24/32.
    • Removed maxFileWrites; higher maxDownloads and tuned maxDecompress now derive from CPU cores.
  • Dependencies

    • Bumped JavaSteam to 1.8.0-10 in Gradle and local JAR paths.

Written for commit 34d0668. Summary will update on new commits.

Summary by CodeRabbit

  • Chores

    • Updated JavaSteam library dependency to the newer snapshot version.
  • Refactor

    • Increased download and decompression resource allocations across speed tiers for higher throughput.
    • Removed a previously configured file-write limit to simplify downloader configuration.
    • Cleaned up logging output for clearer, consistent messages.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

Updated JavaSteam dependency to 1.8.0-10-SNAPSHOT in build config and version catalog. Increased download/decompress ratios for speed tiers and removed the maxFileWrites variable and its DepotDownloader constructor argument; logging adjusted accordingly.

Changes

Cohort / File(s) Summary
Build / Version Catalog
app/build.gradle.kts, gradle/libs.versions.toml
JavaSteam version bumped to 1.8.0-10-SNAPSHOT; app/build.gradle.kts path change applied when localBuild is true.
Download / Steam service
app/src/main/java/app/gamenative/service/SteamService.kt
Increased download/decompress ratios for tiers (8/16/24/32); removed maxFileWrites variable and removed its maxFileWrites argument from DepotDownloader(...); minor log formatting changes.

Sequence Diagram(s)

(omitted — changes do not introduce a new multi-component control flow that requires visualization)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • phobos665

Poem

🐰 I nibbled code beneath the moon,
I changed a version, tuned the tune,
I dropped a variable, let it hop,
Downloads hum and seldom stop—
A little rabbit gave it boost 🌙🐇

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main objective of the PR, which updates JavaSteam and adjusts download/decompression performance ratios.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Comment on lines 216 to 217
implementation(files("../../JavaSteam/build/libs/javasteam-1.8.0-9-SNAPSHOT.jar"))
implementation(files("../../JavaSteam/javasteam-depotdownloader/build/libs/javasteam-depotdownloader-1.8.0-9-SNAPSHOT.jar"))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was changed? My download for Nidhogg is not even starting, it's stuck on "Calculating..."

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, it took a minute but it started downloading eventually... Will try on a larger game

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nidhogg download still stopping at 100% and never completing, that's why we had downgraded to old version...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it eventually finished after a long delay 🤔

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still getting the "Requested exe is invalid" error. I think something is broken...

Updates JavaSteam version, download and decompress ratios to improve download performance
@joshuatam joshuatam force-pushed the improve-download-performance branch from 7ff77a3 to 34d0668 Compare January 23, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants