Skip to content

remove winhandler dependency#1453

Draft
AndreVto wants to merge 1 commit into
utkarshdalal:masterfrom
AndreVto:rm-winhandler
Draft

remove winhandler dependency#1453
AndreVto wants to merge 1 commit into
utkarshdalal:masterfrom
AndreVto:rm-winhandler

Conversation

@AndreVto
Copy link
Copy Markdown
Contributor

@AndreVto AndreVto commented May 17, 2026

Description

(wip) doesn't seem needed? still checking

Recording

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

Removed winhandler.exe from all launch paths. We now start games and tools directly, reducing complexity across GOG, Epic, Amazon, Steam, and Custom Games.

  • Refactors
    • Replaced winhandler.exe wrapping with direct commands in XServerScreen.kt (returns raw executable + args).
    • Standardized fallbacks to explorer.exe and direct paths without extra outer quotes.
    • Updated PreInstallSteps.wrapAsGuestExecutable to use cmd /c directly; wine explorer /desktop flow remains.

Written for commit 6260f99. Summary will update on new commits. Review in cubic

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 17, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a049edb6-02b6-45dc-b7f8-68a9d30c6480

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant