Skip to content

Feat/renderer pipeline#1438

Draft
utkarshdalal wants to merge 3 commits into
masterfrom
feat/renderer-pipeline
Draft

Feat/renderer pipeline#1438
utkarshdalal wants to merge 3 commits into
masterfrom
feat/renderer-pipeline

Conversation

@utkarshdalal
Copy link
Copy Markdown
Owner

@utkarshdalal utkarshdalal commented May 14, 2026

Description

Recording

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

Adds a new Vulkan renderer pipeline that replaces the legacy OpenGL path. Ships a native compositor with optional Adreno Turnip driver injection via adrenotools, new shader-based screen effects, and UI/XServer integration updates; also fixes FPS tracking.

  • New Features

    • Introduces VulkanRenderer with a native VulkanRendererContext and JNI bridge.
    • Vulkan swapchain compositor with window/cursor pipelines and shader-based effects (brightness, contrast, gamma, scaling, FSR/RCAS, FXAA, CRT/NTSC).
    • Optional Adreno driver injection via adrenotools (defaults to system Vulkan on non‑Adreno).
    • XServerView moves from GLSurfaceView to SurfaceView with SurfaceHolder callbacks.
    • UI wired to VulkanRenderer (QuickMenu, ScreenEffectsPanel, ScreenEffectDialog) and screen effects config simplified.
    • FPS counter reliability fix by starting frame display tracking.
  • Dependencies

    • Adds CMake subproject vulkan_renderer (arm64‑v8a only).
    • Links adrenotools; packaging uses pickFirsts for hook libs to avoid conflicts.

Written for commit 1df389b. Summary will update on new commits.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 69855541-bed1-436b-96c0-30c397d92a64

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/renderer-pipeline

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants