You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use a proper API/crate for extracting library paths from cmake rather than reading the cache file which is unstable. This came up in the discussion in https://codeberg.org/tazz4843/whisper-rs/pulls/260.
I'm not familar enough with cmake or linking to judge if this is a good idea - it certianly moves complexity into this crate. could you explain what's this changes and what the issue was?
If it's a caching issue, when does it occur? why doesn't cmake figure out the cache is invalid and reconfigure? do we lose out on caching every build if this feature is enabled?
The code on main reads the cmake cache file to figure out where the system GGML libraries are. This works, but there's no guarantees on the stability of the format. A future cmake could break this build process, though I'm not sure in practice how realistic this possibility is. This PR uses a crate that relies on the stable cmake file API. It offers better stability against potential future cmake changes, at the cost of pulling in a build dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a proper API/crate for extracting library paths from cmake rather than reading the cache file which is unstable. This came up in the discussion in https://codeberg.org/tazz4843/whisper-rs/pulls/260.