-
Notifications
You must be signed in to change notification settings - Fork 3
コードブロックの行ハイライトの設定を追加 #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
コードブロックの行ハイライトの設定を追加 #903
Conversation
Deploying utcode-learn with
|
| Latest commit: |
13c89ed
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e4af386e.utcode-learn.pages.dev |
| Branch Preview URL: | https://add-codeblock-line-highlight.utcode-learn.pages.dev |
| .docusaurus-highlight-code-line { | ||
| background-color: rgb(72, 77, 91); | ||
| display: block; | ||
| margin: 0 calc(-1 * var(--ifm-pre-padding)); | ||
| padding: 0 var(--ifm-pre-padding); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
もともとなぜ設定していたのか不明ですが、削除してデフォルト設定に任せる形で良さそうに思います。
現時点で行ハイライト機能を使用している部分はないため影響はないと思われます。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modernizes the code block line highlighting configuration by migrating from the deprecated class-based approach to the CSS variable-based approach recommended by Docusaurus. The changes align with Docusaurus's classic-typescript template defaults and maintain consistency with the project's existing theme configuration (GitHub for light mode, Dracula for dark mode).
- Replaces the custom
.docusaurus-highlight-code-lineclass styling with the--docusaurus-highlighted-code-line-bgCSS variable - Configures appropriate highlight colors for both light (
rgba(0, 0, 0, 0.1)) and dark (rgba(0, 0, 0, 0.3)) themes - Removes manual display and padding styles that are now handled internally by Docusaurus
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chvmvd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良いと思います!
丁寧な説明もありがとうございます!!!
行ハイライトの色の設定を追加しました。
ライトテーマ
ダークテーマ
備考
github、ダークテーマはdraculaを使っているので、行ハイライト色もデフォルトのものを設定しました。