-
Notifications
You must be signed in to change notification settings - Fork 3
サンプルプログラムの内容を最新にアップデート #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying utcode-learn with
|
| Latest commit: |
ff86570
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://07da577a.utcode-learn.pages.dev |
| Branch Preview URL: | https://update-samples.utcode-learn.pages.dev |
| @@ -1,14 +1,14 @@ | |||
| <!doctype html> | |||
| <html lang="ja"> | |||
| <head> | |||
| <meta charset="utf-8" /> | |||
| <meta charset="UTF-8" /> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viteがデフォルトで生成するファイルに合わせた形です。
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Vite App</title> | ||
| </head> | ||
| <body> | ||
| <div> | ||
| <canvas id="myChart"></canvas> | ||
| </div> | ||
| <script type="module" src="/main.js"></script> | ||
| <script type="module" src="/src/main.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viteがデフォルトで生成するファイルに合わせた形です。
| @@ -2,13 +2,16 @@ | |||
| "name": "chartjs", | |||
| "private": true, | |||
| "version": "0.0.0", | |||
| "type": "module", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viteがデフォルトで生成するファイルに合わせた形です。
| "dev": "vite", | ||
| "build": "vite build", | ||
| "preview": "vite preview" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viteがデフォルトで生成するファイルに合わせた形です。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viteがデフォルトで生成するファイルから変更は加えていません。
| "build": "tsc -b && vite build", | ||
| "lint": "eslint .", | ||
| "preview": "vite preview" | ||
| }, | ||
| "dependencies": { | ||
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1" | ||
| "react": "^19.1.0", | ||
| "react-dom": "^19.1.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/react": "^18.3.3", | ||
| "@types/react-dom": "^18.3.0", | ||
| "@vitejs/plugin-react": "^4.3.1", | ||
| "typescript": "^5.5.4", | ||
| "vite": "^5.4.1" | ||
| "@eslint/js": "^9.30.1", | ||
| "@types/react": "^19.1.8", | ||
| "@types/react-dom": "^19.1.6", | ||
| "@vitejs/plugin-react": "^4.6.0", | ||
| "eslint": "^9.30.1", | ||
| "eslint-plugin-react-hooks": "^5.2.0", | ||
| "eslint-plugin-react-refresh": "^0.4.20", | ||
| "globals": "^16.3.0", | ||
| "typescript": "~5.8.3", | ||
| "typescript-eslint": "^8.35.1", | ||
| "vite": "^7.0.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viteがデフォルトで生成するファイルから変更は加えていません。
| import { StrictMode } from "react"; | ||
| import { createRoot } from "react-dom/client"; | ||
| import App from "./App.tsx"; | ||
|
|
||
| ReactDOM.createRoot(document.getElementById("root") as HTMLElement).render( | ||
| <React.StrictMode> | ||
| createRoot(document.getElementById("root")!).render( | ||
| <StrictMode> | ||
| <App /> | ||
| </React.StrictMode>, | ||
| </StrictMode>, | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viteがデフォルトで生成するファイルから変更は加えていません。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viteがデフォルトで生成するファイルから変更は加えていません。
chelproc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
全部は見切れないですが多分大丈夫・・・?
サンプルプログラムのパッケージのメンテがしんどいので何か良き方法があるといいですね👀
.gitignoreで一部がnode_modulesなどになっていたため、/node_modulesの方に統一しました。(もともとは、/node_modulesに統一されていましたが、解答例を追加しました。 #63 の時に追加されたものがnode_modulesの表記になっていたことが主な原因と思われます。)